Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(firebase): improve docs #1556

Merged
merged 2 commits into from
Aug 11, 2023
Merged

docs(firebase): improve docs #1556

merged 2 commits into from
Aug 11, 2023

Conversation

luc122c
Copy link
Contributor

@luc122c luc122c commented Aug 9, 2023 •
edited
Loading

🔗 Linked issue

Fixes #1555

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I tried implementing the new Gen2 preset, and noticed there were a couple of inconsitencies between the code, and the docs. This PR fixes them.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Aug 9, 2023

✅ Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio ↗︎ View Live Preview 37151de

@pi0 pi0 changed the title fix(docs): Fix inconsistencies between code and docs doc(firebase): improve docs Aug 9, 2023
@pi0 pi0 changed the title doc(firebase): improve docs docs(firebase): improve docs Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023 •
edited
Loading

Codecov Report

Merging #1556 (37151de) into main (7fa8408) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1556   +/-   ##
=======================================
  Coverage   76.49%   76.49%           
=======================================
  Files          73       73           
  Lines        7580     7580           
  Branches      751      751           
=======================================
  Hits         5798     5798           
  Misses       1781     1781           
  Partials        1        1

@pi0 pi0 merged commit c640b04 into nitrojs:main Aug 11, 2023
8 checks passed
@pi0
Copy link
Member

pi0 commented Aug 11, 2023

Thanks!

@pi0 pi0 mentioned this pull request Aug 21, 2023
Closed
@luc122c luc122c mentioned this pull request Aug 29, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Firebase Preset improvements
2 participants
@luc122c @pi0